Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: base/debug/BUILD.gn

Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/json/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("debug") { 5 source_set("debug") {
6 sources = [ 6 sources = [
7 "alias.cc", 7 "alias.cc",
8 "alias.h", 8 "alias.h",
9 "asan_invalid_access.cc", 9 "asan_invalid_access.cc",
10 "asan_invalid_access.h", 10 "asan_invalid_access.h",
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 if (is_nacl) { 49 if (is_nacl) {
50 sources -= [ 50 sources -= [
51 "crash_logging.cc", 51 "crash_logging.cc",
52 "crash_logging.h", 52 "crash_logging.h",
53 "stack_trace.cc", 53 "stack_trace.cc",
54 "stack_trace_posix.cc", 54 "stack_trace_posix.cc",
55 ] 55 ]
56 } 56 }
57 57
58 defines = [ "BASE_IMPLEMENTATION" ] 58 configs += [ "//base:base_implementation" ]
59 59
60 deps = [ 60 deps = [
61 "//base/memory", 61 "//base/memory",
62 "//base/process", 62 "//base/process",
63 ] 63 ]
64 64
65 if (is_linux) { 65 if (is_linux) {
66 defines += [ "USE_SYMBOLIZE" ] 66 defines = [ "USE_SYMBOLIZE" ]
67 deps += [ "//base/third_party/symbolize" ] 67 deps += [ "//base/third_party/symbolize" ]
68 } 68 }
69 69
70 allow_circular_includes_from = [ 70 allow_circular_includes_from = [
71 "//base/memory", 71 "//base/memory",
72 "//base/process", 72 "//base/process",
73 ] 73 ]
74 74
75 visibility = [ "//base/*" ] 75 visibility = [ "//base/*" ]
76 } 76 }
OLDNEW
« no previous file with comments | « base/BUILD.gn ('k') | base/json/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698