base/third_party/nspr/BUILD.gn - Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/nspr/BUILD.gn

Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/third_party/nspr/BUILD.gn

diff --git a/base/third_party/nspr/BUILD.gn b/base/third_party/nspr/BUILD.gn

index a67e1683148e7c17a5b17103eee0589096b01db8..034f37b275ce1c3ab67b66b5d0705ed57b04f655 100644

--- a/base/third_party/nspr/BUILD.gn

+++ b/base/third_party/nspr/BUILD.gn

@@ -12,7 +12,7 @@ source_set("nspr") {

# In GYP this project is part of base, so it uses the base implementation

# define. TODO(brettw) rename this define.

- defines = [ "BASE_IMPLEMENTATION" ]

+ configs += [ "//base:base_implementation" ]

if (is_android && !is_debug) {

configs -= [ "//build/config/compiler:optimize" ]

« no previous file with comments | « base/process/BUILD.gn ('k') | base/trace_event/BUILD.gn » ('j') | no next file with comments »