Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url (Closed)

Created:
5 years, 9 months ago by dschuyler
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, gcasto+watchlist_chromium.org, groby-ooo-7-16, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BitmapFetcher] Added reference to OnFetchComplete url. It looks like other uses of GURL pass by const reference. This call is by const value: virtual void OnFetchComplete(const GURL url, const SkBitmap* bitmap) = 0; I suspect this was a mistype. BUG=458681 Committed: https://crrev.com/8df543e37dc4d2ee46c98bbcf546b683550d4aaf Cr-Commit-Position: refs/heads/master@{#322833}

Patch Set 1 #

Patch Set 2 : Fix for GURL reference #

Patch Set 3 : chaging OnFetchComplete for bitmap fetcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/image_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/image_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/account_avatar_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/account_avatar_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dschuyler
5 years, 8 months ago (2015-03-30 17:30:31 UTC) #2
groby-ooo-7-16
From the bitmap-fetcher side - yes, that's a typo. Thanks for fixing.
5 years, 8 months ago (2015-03-30 17:57:54 UTC) #3
Lei Zhang
lgtm
5 years, 8 months ago (2015-03-30 18:23:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016003004/40001
5 years, 8 months ago (2015-03-30 18:24:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-30 19:22:46 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 19:23:16 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8df543e37dc4d2ee46c98bbcf546b683550d4aaf
Cr-Commit-Position: refs/heads/master@{#322833}

Powered by Google App Engine
This is Rietveld 408576698