chrome/browser/banners/app_banner_data_fetcher.h - Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chaging OnFetchComplete for bitmap fetcher Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_data_fetcher.h

diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h

index edb534b65c2b113646052a4ae7db0d9dbca41ea3..085e920d4e4c47f5ef11cdcce145be663b246045 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.h

+++ b/chrome/browser/banners/app_banner_data_fetcher.h

@@ -123,7 +123,7 @@ class AppBannerDataFetcher

// Callbacks for data retrieval.

void OnDidGetManifest(const content::Manifest& manifest);

void OnDidCheckHasServiceWorker(bool has_service_worker);

- void OnFetchComplete(const GURL url, const SkBitmap* icon) override;

+ void OnFetchComplete(const GURL& url, const SkBitmap* icon) override;

// Shows a banner for the app, if the given |icon| is valid.

virtual void ShowBanner(const SkBitmap* icon);

« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | no next file with comments »