chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h - Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h

Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chaging OnFetchComplete for bitmap fetcher Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h

diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h b/chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h

index b8888c18edc6756725cffbee5a4524d94ae5b870..255113568ca240b306aad8403c78542991c99572 100644

--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h

+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h

@@ -20,7 +20,7 @@ class BitmapFetcherDelegate {

// request succeeds. |url| is the URL that was originally fetched so we can

// match up the bitmap with a specific request. |bitmap| may be NULL if the

// image fails to be downloaded or decoded.

- virtual void OnFetchComplete(const GURL url, const SkBitmap* bitmap) = 0;

+ virtual void OnFetchComplete(const GURL& url, const SkBitmap* bitmap) = 0;

protected:

virtual ~BitmapFetcherDelegate() {}