chrome/browser/image_holder.cc - Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/image_holder.cc

Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chaging OnFetchComplete for bitmap fetcher Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/image_holder.cc

diff --git a/chrome/browser/image_holder.cc b/chrome/browser/image_holder.cc

index 960b057e75bd86bf67fc24df0af9125c45ac2303..852f670d3594e691d4ab91d87b044921ba21e1f7 100644

--- a/chrome/browser/image_holder.cc

+++ b/chrome/browser/image_holder.cc

@@ -77,7 +77,7 @@ void ImageHolder::StartFetch() {

}

// Method inherited from BitmapFetcher delegate.

-void ImageHolder::OnFetchComplete(const GURL url, const SkBitmap* bitmap) {

+void ImageHolder::OnFetchComplete(const GURL& url, const SkBitmap* bitmap) {

// TODO(petewil): Should I retry if a fetch fails?

// Match the bitmap to the URL to put it into the image with the correct scale

// factor.

« no previous file with comments | « chrome/browser/image_holder.h ('k') | chrome/browser/profiles/profile_avatar_downloader.h » ('j') | no next file with comments »