chrome/browser/banners/app_banner_data_fetcher.cc - Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1016003004: [BitmapFetcher] Added reference to OnFetchComplete url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chaging OnFetchComplete for bitmap fetcher Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.h ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc

index cbb8e790acda0032a550f709e05ccc4750d99d33..a32ba763ea3ed522bd0b827f218c4918e9d17be8 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher.cc

@@ -288,7 +288,7 @@ void AppBannerDataFetcher::OnDidCheckHasServiceWorker(

Cancel();

}

-void AppBannerDataFetcher::OnFetchComplete(const GURL url,

+void AppBannerDataFetcher::OnFetchComplete(const GURL& url,

const SkBitmap* icon) {

if (is_active_)

ShowBanner(icon);

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.h ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc » ('j') | no next file with comments »