Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 101473003: Do not allow creating dummy notifier id from production, for safety. (Closed)

Created:
7 years ago by Jun Mukai
Modified:
7 years ago
Reviewers:
James Cook, dewittj
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, Robert Sesek
Visibility:
Public.

Description

Do not allow creating dummy notifier id in production. Somehow NotifierId() default constructor still exists but this is really misleading, because it creates an id only for test use. To apply this rule explicitly, move this constructor to private. BUG=327033 R=dewittj@chromium.org TBR=jamescook@chromium.org TEST=no functional change, compile succeeds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239993

Patch Set 1 #

Patch Set 2 : mac fix #

Patch Set 3 : mac fix 2 #

Patch Set 4 : fix #

Patch Set 5 : fix #

Patch Set 6 : moar fix #

Patch Set 7 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -41 lines) Patch
M ash/shell/window_type_launcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 2 10 chunks +17 lines, -8 lines 0 comments Download
M ui/message_center/cocoa/popup_collection_unittest.mm View 1 2 3 13 chunks +18 lines, -10 lines 0 comments Download
M ui/message_center/cocoa/popup_controller_unittest.mm View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/tray_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller_unittest.mm View 1 2 9 chunks +12 lines, -8 lines 0 comments Download
M ui/message_center/message_center.h View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M ui/message_center/message_center_tray_unittest.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M ui/message_center/notifier_settings.h View 1 2 3 4 5 3 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
7 years ago (2013-12-10 07:57:07 UTC) #1
dewittj
lgtm
7 years ago (2013-12-10 17:03:15 UTC) #2
Jun Mukai
+jamescook as TBR, the change of ash/shell/window_type_launcher.cc is trivial. cc: rsesek for the change of ...
7 years ago (2013-12-10 18:24:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/101473003/100001
7 years ago (2013-12-10 18:25:56 UTC) #4
James Cook
lgtm
7 years ago (2013-12-10 18:43:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-10 19:51:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/101473003/120001
7 years ago (2013-12-10 21:44:05 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-11 03:22:23 UTC) #8
Message was sent while issue was closed.
Change committed as 239993

Powered by Google App Engine
This is Rietveld 408576698