Do not allow creating dummy notifier id from production, for safety.

ui/message_center/message_center_tray_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/message_center_tray.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification_types.h"
@@ skipping 24 matching lines @@
     return NULL;
   }
 
   bool show_popups_success_;
   bool show_message_center_success_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockDelegate);
 };
 
+}  // namespace
+
 class MessageCenterTrayTest : public testing::Test {
  public:
   MessageCenterTrayTest() {}
   virtual ~MessageCenterTrayTest() {}
 
   virtual void SetUp() {
     MessageCenter::Initialize();
     delegate_.reset(new MockDelegate);
     message_center_ = MessageCenter::Get();
     message_center_tray_.reset(
         new MessageCenterTray(delegate_.get(), message_center_));
   }
 
   virtual void TearDown() {
     message_center_tray_.reset();
     delegate_.reset();
     message_center_ = NULL;
     MessageCenter::Shutdown();
   }
 
  protected:
+  NotifierId DummyNotifierId() {
+    return NotifierId();
+  }
+
   void AddNotification(const std::string& id) {
     scoped_ptr<Notification> notification(
         new Notification(message_center::NOTIFICATION_TYPE_SIMPLE,
                          id,
                          ASCIIToUTF16("Test Web Notification"),
                          ASCIIToUTF16("Notification message body."),
                          gfx::Image(),
                          ASCIIToUTF16("www.test.org"),
-                         NotifierId(),
+                         DummyNotifierId(),
                          message_center::RichNotificationData(),
                          NULL /* delegate */));
     message_center_->AddNotification(notification.Pass());
   }
   scoped_ptr<MockDelegate> delegate_;
   scoped_ptr<MessageCenterTray> message_center_tray_;
   MessageCenter* message_center_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MessageCenterTrayTest);
 };
 
-}  // namespace
-
 TEST_F(MessageCenterTrayTest, BasicMessageCenter) {
   ASSERT_FALSE(message_center_tray_->popups_visible());
   ASSERT_FALSE(message_center_tray_->message_center_visible());
 
   bool shown = message_center_tray_->ShowMessageCenterBubble();
   EXPECT_TRUE(shown);
 
   ASSERT_FALSE(message_center_tray_->popups_visible());
   ASSERT_TRUE(message_center_tray_->message_center_visible());
 
@@ skipping 72 matching lines @@
   ASSERT_FALSE(message_center_tray_->popups_visible());
   ASSERT_FALSE(message_center_tray_->message_center_visible());
 
   scoped_ptr<Notification> notification(
       new Notification(message_center::NOTIFICATION_TYPE_SIMPLE,
                        "MessageCenterReopnPopupsForSystemPriority",
                        ASCIIToUTF16("Test Web Notification"),
                        ASCIIToUTF16("Notification message body."),
                        gfx::Image(),
                        ASCIIToUTF16("www.test.org"),
-                       NotifierId(),
+                       DummyNotifierId(),
                        message_center::RichNotificationData(),
                        NULL /* delegate */));
   notification->SetSystemPriority();
   message_center_->AddNotification(notification.Pass());
 
   ASSERT_TRUE(message_center_tray_->popups_visible());
   ASSERT_FALSE(message_center_tray_->message_center_visible());
 
   bool shown = message_center_tray_->ShowMessageCenterBubble();
   EXPECT_TRUE(shown);
@@ skipping 38 matching lines @@
   ASSERT_FALSE(message_center_tray_->popups_visible());
   ASSERT_FALSE(message_center_tray_->message_center_visible());
 
   message_center_tray_->HidePopupBubble();
 
   ASSERT_FALSE(message_center_tray_->popups_visible());
   ASSERT_FALSE(message_center_tray_->message_center_visible());
 }
 
 }  // namespace message_center