Do not allow creating dummy notifier id from production, for safety.

ui/message_center/cocoa/notification_controller_unittest.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/message_center/cocoa/notification_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 37 matching lines @@
   std::string last_removed_id_;
   bool last_removed_by_user_;
   int remove_count_;
 
   std::string last_clicked_id_;
   int last_clicked_index_;
 
   DISALLOW_COPY_AND_ASSIGN(MockMessageCenter);
 };
 
-}
+}  // namespace
 
 @implementation MCNotificationController (TestingInterface)
 - (NSButton*)closeButton {
   return closeButton_.get();
 }
 
 - (NSButton*)secondButton {
   // The buttons are in Cocoa-y-order, so the 2nd button is first.
   NSView* view = [[bottomView_ subviews] objectAtIndex:0];
   return base::mac::ObjCCastStrict<NSButton>(view);
@@ skipping 17 matching lines @@
 
 - (NSTextView*)contextMessageView {
   return contextMessage_.get();
 }
 
 - (NSView*)listView {
   return listView_.get();
 }
 @end
 
+namespace message_center {
+
 class NotificationControllerTest : public ui::CocoaTest {
  public:
   NSImage* TestIcon() {
     return [NSImage imageNamed:NSImageNameUser];
   }
+
+ protected:
+  message_center::NotifierId DummyNotifierId() {
+    return message_center::NotifierId();
+  }
 };
 
 TEST_F(NotificationControllerTest, BasicLayout) {
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_SIMPLE,
           "",
           ASCIIToUTF16("Added to circles"),
           ASCIIToUTF16("Jonathan and 5 others"),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           message_center::RichNotificationData(),
           NULL));
   notification->set_icon(gfx::Image([TestIcon() retain]));
 
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:NULL]);
   [controller view];
 
   EXPECT_EQ(TestIcon(), [[controller iconView] image]);
   EXPECT_EQ(base::SysNSStringToUTF16([[controller titleView] string]),
             notification->title());
   EXPECT_EQ(base::SysNSStringToUTF16([[controller messageView] string]),
             notification->message());
   EXPECT_EQ(controller.get(), [[controller closeButton] target]);
 }
 
 TEST_F(NotificationControllerTest, OverflowText) {
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_SIMPLE,
           "",
           ASCIIToUTF16("This is a much longer title that should wrap "
                        "multiple lines."),
           ASCIIToUTF16("And even the message is long. This sure is a wordy "
                        "notification. Are you really going to read this "
                        "entire thing?"),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           message_center::RichNotificationData(),
           NULL));
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:NULL]);
   [controller view];
 
   EXPECT_GT(NSHeight([[controller view] frame]),
             message_center::kNotificationIconSize);
 }
 
 TEST_F(NotificationControllerTest, Close) {
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_SIMPLE,
           "an_id",
           string16(),
           string16(),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           message_center::RichNotificationData(),
           NULL));
   MockMessageCenter message_center;
 
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:&message_center]);
   [controller view];
 
   [[controller closeButton] performClick:nil];
 
   EXPECT_EQ(1, message_center.remove_count());
   EXPECT_EQ("an_id", message_center.last_removed_id());
   EXPECT_TRUE(message_center.last_removed_by_user());
 }
 
 TEST_F(NotificationControllerTest, Update) {
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_SIMPLE,
           "",
           ASCIIToUTF16("A simple title"),
           ASCIIToUTF16("This message isn't too long and should fit in the"
                        "default bounds."),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           message_center::RichNotificationData(),
           NULL));
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:NULL]);
 
   // Set up the default layout.
   [controller view];
   EXPECT_EQ(NSHeight([[controller view] frame]),
             message_center::kNotificationIconSize);
@@ skipping 15 matching lines @@
   optional.buttons.push_back(button2);
 
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_BASE_FORMAT,
           "an_id",
           string16(),
           string16(),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           optional,
           NULL));
   MockMessageCenter message_center;
 
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:&message_center]);
   [controller view];
 
   [[controller secondButton] performClick:nil];
 
   EXPECT_EQ("an_id", message_center.last_clicked_id());
   EXPECT_EQ(1, message_center.last_clicked_index());
 }
 
 TEST_F(NotificationControllerTest, Image) {
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_BASE_FORMAT,
           "an_id",
           string16(),
           string16(),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           message_center::RichNotificationData(),
           NULL));
   NSImage* image = [NSImage imageNamed:NSImageNameFolder];
   notification->set_image(gfx::Image([image retain]));
 
   MockMessageCenter message_center;
 
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:&message_center]);
@@ skipping 21 matching lines @@
   optional.context_message = UTF8ToUTF16("Context Message");
 
   scoped_ptr<message_center::Notification> notification(
       new message_center::Notification(
           message_center::NOTIFICATION_TYPE_BASE_FORMAT,
           "an_id",
           UTF8ToUTF16("Notification Title"),
           UTF8ToUTF16("Notification Message - should be hidden"),
           gfx::Image(),
           string16(),
-          message_center::NotifierId(),
+          DummyNotifierId(),
           optional,
           NULL));
 
   MockMessageCenter message_center;
   base::scoped_nsobject<MCNotificationController> controller(
       [[MCNotificationController alloc] initWithNotification:notification.get()
                                                messageCenter:&message_center]);
   [controller view];
 
   EXPECT_FALSE([[controller titleView] isHidden]);
   EXPECT_TRUE([[controller messageView] isHidden]);
   EXPECT_FALSE([[controller contextMessageView] isHidden]);
 
   EXPECT_EQ(3u, [[[controller listView] subviews] count]);
   EXPECT_LT(NSMaxY([[controller listView] frame]),
             NSMinY([[controller titleView] frame]));
 }
+
+}  // namespace message_center