chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc - Issue 101473003: Do not allow creating dummy notifier id from production, for safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc

Issue 101473003: Do not allow creating dummy notifier id from production, for safety. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc ('k') | ui/message_center/cocoa/notification_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc

diff --git a/chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc b/chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc

index 6d4ea2531ab198fef255fae19651da2eafd2d51b..94a48c7b894d0a1584c8d81e55b0b21b35a73b7a 100644

--- a/chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc

+++ b/chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc

@@ -62,7 +62,8 @@ class LoginStateNotificationBlockerChromeOSTest

TEST_F(LoginStateNotificationBlockerChromeOSTest, BaseTest) {

// Default status: OOBE.

- message_center::NotifierId notifier_id;

+ message_center::NotifierId notifier_id(

+ message_center::NotifierId::APPLICATION, "test-notifier");

EXPECT_FALSE(ShouldShowNotificationAsPopup(notifier_id));

// Login screen.