chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc - Issue 101473003: Do not allow creating dummy notifier id from production, for safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

Issue 101473003: Do not allow creating dummy notifier id from production, for safety. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/shell/window_type_launcher.cc ('k') | chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

diff --git a/chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc b/chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

index 6e312a5e00f58f5b2f0b15bbb2db1715b3520453..1cd02863acac958e40e246725b491e3a1793398a 100644

--- a/chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

+++ b/chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

@@ -89,7 +89,8 @@ IN_PROC_BROWSER_TEST_F(LoginStateNotificationBlockerChromeOSBrowserTest,

IN_PROC_BROWSER_TEST_F(LoginStateNotificationBlockerChromeOSBrowserTest,

BaseTest) {

CreateBlocker();

- message_center::NotifierId notifier_id;

+ message_center::NotifierId notifier_id(

+ message_center::NotifierId::APPLICATION, "test-notifier");

// Logged in as a normal user.

EXPECT_CALL(login_utils(), DoBrowserLaunch(_, _)).Times(1);