Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
vivekg, aandrey+blink_chromium.org, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vivekg_samsung, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. Many of the conversion routines e.g. toDouble, toInt, toFloat etc. calls v8::Isolate::GetCurrent in order to obtain the current isolate. Instead of calling for this method, these routines must be passed with Isolate as the argument which can be further used. BUG=424446 R=haraken@chromium.org, jl@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -356 lines) Patch
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 2 chunks +21 lines, -21 lines 0 comments Download
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 8 chunks +54 lines, -54 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 17 chunks +37 lines, -46 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/V8DeviceOrientationEventCustom.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 2 chunks +15 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 19 chunks +21 lines, -21 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 138 chunks +148 lines, -148 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/RequestInit.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
Sorry for the bigger patch but combined all mechanical changes into one single patch. Hope ...
5 years, 9 months ago (2015-03-16 12:22:29 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-16 23:23:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013643002/1
5 years, 9 months ago (2015-03-17 00:23:55 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:28:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191958

Powered by Google App Engine
This is Rietveld 408576698