Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: Source/bindings/tests/results/core/UnionTypesCore.cpp

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/UnionTypesCore.cpp
diff --git a/Source/bindings/tests/results/core/UnionTypesCore.cpp b/Source/bindings/tests/results/core/UnionTypesCore.cpp
index c17ed46496a1347c0b60f89b635e4e2428798710..9597b32a9223f2b9d6fcf2ae84dd89eb03ab701a 100644
--- a/Source/bindings/tests/results/core/UnionTypesCore.cpp
+++ b/Source/bindings/tests/results/core/UnionTypesCore.cpp
@@ -224,7 +224,7 @@ void V8BooleanOrStringOrUnrestrictedDouble::toImpl(v8::Isolate* isolate, v8::Loc
}
if (v8Value->IsNumber()) {
- double cppValue = toDouble(v8Value, exceptionState);
+ double cppValue = toDouble(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setUnrestrictedDouble(cppValue);
@@ -316,7 +316,7 @@ void V8DoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
return;
if (v8Value->IsNumber()) {
- double cppValue = toRestrictedDouble(v8Value, exceptionState);
+ double cppValue = toRestrictedDouble(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setDouble(cppValue);
@@ -615,7 +615,7 @@ void V8StringOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
return;
if (v8Value->IsNumber()) {
- double cppValue = toRestrictedDouble(v8Value, exceptionState);
+ double cppValue = toRestrictedDouble(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setDouble(cppValue);
@@ -800,7 +800,7 @@ void V8TestEnumOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Val
return;
if (v8Value->IsNumber()) {
- double cppValue = toRestrictedDouble(v8Value, exceptionState);
+ double cppValue = toRestrictedDouble(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setDouble(cppValue);
@@ -1081,7 +1081,7 @@ void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8
}
if (v8Value->IsNumber()) {
- int cppValue = toInt32(v8Value, exceptionState);
+ int cppValue = toInt32(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);
@@ -1089,7 +1089,7 @@ void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8
}
{
- int cppValue = toInt32(v8Value, exceptionState);
+ int cppValue = toInt32(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);
@@ -1354,7 +1354,7 @@ void V8UnrestrictedDoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Va
return;
if (v8Value->IsNumber()) {
- double cppValue = toDouble(v8Value, exceptionState);
+ double cppValue = toDouble(isolate, v8Value, exceptionState);
if (exceptionState.hadException())
return;
impl.setUnrestrictedDouble(cppValue);
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698