Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterface2.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterface2.cpp b/Source/bindings/tests/results/core/V8TestInterface2.cpp
index f03a154cd5d9fd0b43a33daf6f8bf4435bb18e3e..7304fc81c0e1c9af7402879ccde6789dc2195210 100644
--- a/Source/bindings/tests/results/core/V8TestInterface2.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterface2.cpp
@@ -47,7 +47,7 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());
unsigned index;
{
- index = toUInt32(info[0], exceptionState);
+ index = toUInt32(info.GetIsolate(), info[0], exceptionState);
if (exceptionState.throwIfNeeded())
return;
}
@@ -78,7 +78,7 @@ static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
unsigned index;
TestInterfaceEmpty* value;
{
- index = toUInt32(info[0], exceptionState);
+ index = toUInt32(info.GetIsolate(), info[0], exceptionState);
if (exceptionState.throwIfNeeded())
return;
value = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[1]);
@@ -114,7 +114,7 @@ static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());
unsigned index;
{
- index = toUInt32(info[0], exceptionState);
+ index = toUInt32(info.GetIsolate(), info[0], exceptionState);
if (exceptionState.throwIfNeeded())
return;
}
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface3.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698