Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index e38036830e1aa6593c7668e46aee1a10ae84f181..b7d49e109c9d6405b84a029f2ec64acdcc9b5ef2 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -86,7 +86,7 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

if (!stringArg.prepare())

return;

defaultUndefinedOptionalBooleanArg = info[1]->BooleanValue();

- defaultUndefinedOptionalLongArg = toInt32(info[2], exceptionState);

+ defaultUndefinedOptionalLongArg = toInt32(info.GetIsolate(), info[2], exceptionState);

if (exceptionState.throwIfNeeded())

return;

defaultUndefinedOptionalStringArg = info[3];