Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp - Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface3.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

index 138527f83c7a73908493914dd392c92c997491d1..e8ad2b869587dc40e9280f67201d2b9b8bd40d3a 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

@@ -77,7 +77,7 @@ static void doNotCheckSecurityLongAttributeAttributeSetter(v8::Local<v8::Value>

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "doNotCheckSecurityLongAttribute", "TestInterfaceCheckSecurity", holder, info.GetIsolate());

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

- int cppValue = toInt32(v8Value, exceptionState);

+ int cppValue = toInt32(info.GetIsolate(), v8Value, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setDoNotCheckSecurityLongAttribute(cppValue);

@@ -124,7 +124,7 @@ static void doNotCheckSecurityOnSetterLongAttributeAttributeSetter(v8::Local<v8: