Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Jeffrey Yasskin, nasko
CC:
chromium-reviews, michaeln, devtools-reviews_chromium.org, benjhayden+dwatch_chromium.org, riju_, mlamouri+watch-sensors_chromium.org, Michael van Ouwerkerk, jam, timvolodine, sievers+watch_chromium.org, jbauman+watch_chromium.org, rginda+watch_chromium.org, dcheng, darin-cc_chromium.org, yurys, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, aandrey+blink_chromium.org, asanka, kinuko+watch, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* BUG=466848 Committed: https://crrev.com/fbcdc27a22dd7ce7308de1dddd6377aa348a9b4a Cr-Commit-Position: refs/heads/master@{#320527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -228 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M content/browser/browser_context.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_ipc_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/cocoa/system_hotkey_helper_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/compositor/software_output_device_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/device_monitor_mac.mm View 13 chunks +17 lines, -17 lines 0 comments Download
M content/browser/device_monitor_udev.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_sensors/device_light_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_sensors/device_motion_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_sensors/device_orientation_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/devtools/devtools_netlog_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/download/base_file_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 34 chunks +39 lines, -39 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M content/browser/download/drag_download_file.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/download/save_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_file_manager.cc View 22 chunks +24 lines, -24 lines 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mostyn Bramley-Moore
@Jeffrey: does this sort of thing look worthwhile to you? If so, I can run ...
5 years, 9 months ago (2015-03-12 23:55:50 UTC) #2
Jeffrey Yasskin
On 2015/03/12 23:55:50, Mostyn Bramley-Moore wrote: > @Jeffrey: does this sort of thing look worthwhile ...
5 years, 9 months ago (2015-03-13 01:04:19 UTC) #3
Mostyn Bramley-Moore
@nasko: can you give this OWNERS approval?
5 years, 9 months ago (2015-03-13 07:59:16 UTC) #5
nasko
LGTM
5 years, 9 months ago (2015-03-13 16:24:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008613002/1
5 years, 9 months ago (2015-03-13 16:41:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 17:59:06 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 18:00:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbcdc27a22dd7ce7308de1dddd6377aa348a9b4a
Cr-Commit-Position: refs/heads/master@{#320527}

Powered by Google App Engine
This is Rietveld 408576698