content/browser/devtools/devtools_agent_host_impl.cc - Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/device_orientation_message_filter.cc ('k') | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_agent_host_impl.cc

diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc

index 213ae9780240ccd0269791cb9ea24e78e9465a7d..2c55fade8043bee655e5c7291de4e23dd5b520e2 100644

--- a/content/browser/devtools/devtools_agent_host_impl.cc

+++ b/content/browser/devtools/devtools_agent_host_impl.cc

@@ -67,12 +67,12 @@ scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::GetForWorker(

DevToolsAgentHostImpl::DevToolsAgentHostImpl()

: id_(base::GenerateGUID()),

client_(NULL) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

g_instances.Get()[id_] = this;

}

DevToolsAgentHostImpl::~DevToolsAgentHostImpl() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

g_instances.Get().erase(g_instances.Get().find(id_));

}