content/browser/cocoa/system_hotkey_helper_mac.mm - Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cocoa/system_hotkey_helper_mac.mm

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_message_filter.cc ('k') | content/browser/compositor/software_output_device_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cocoa/system_hotkey_helper_mac.mm

diff --git a/content/browser/cocoa/system_hotkey_helper_mac.mm b/content/browser/cocoa/system_hotkey_helper_mac.mm

index 68c52820ef36baffe6edbbb572c4ecf0d4a06dc0..7e79572a1a286a8a999dfcb7e0cf82b3d8ba0a96 100644

--- a/content/browser/cocoa/system_hotkey_helper_mac.mm

+++ b/content/browser/cocoa/system_hotkey_helper_mac.mm

@@ -45,7 +45,7 @@ SystemHotkeyHelperMac::~SystemHotkeyHelperMac() {

}

void SystemHotkeyHelperMac::LoadSystemHotkeys() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

std::string library_path(base::mac::GetUserLibraryPath().value());

NSString* expanded_file_path =

@@ -67,7 +67,7 @@ void SystemHotkeyHelperMac::LoadSystemHotkeys() {

}

void SystemHotkeyHelperMac::FileDidLoad(NSDictionary* dictionary) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

bool success = map()->ParseDictionary(dictionary);

UMA_HISTOGRAM_BOOLEAN("OSX.SystemHotkeyMap.LoadSuccess", success);