content/browser/devtools/devtools_netlog_observer.cc - Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_netlog_observer.cc

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_netlog_observer.cc

diff --git a/content/browser/devtools/devtools_netlog_observer.cc b/content/browser/devtools/devtools_netlog_observer.cc

index 2e8495200ba519169b8a03d31dd09dd047b86b3d..4406aea998b1cb6c7451fd4079957e304586f660 100644

--- a/content/browser/devtools/devtools_netlog_observer.cc

+++ b/content/browser/devtools/devtools_netlog_observer.cc

@@ -46,7 +46,7 @@ void DevToolsNetLogObserver::OnAddEntry(const net::NetLog::Entry& entry) {

void DevToolsNetLogObserver::OnAddURLRequestEntry(

const net::NetLog::Entry& entry) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

bool is_begin = entry.phase() == net::NetLog::PHASE_BEGIN;

bool is_end = entry.phase() == net::NetLog::PHASE_END;

@@ -174,7 +174,7 @@ void DevToolsNetLogObserver::Attach() {

}

void DevToolsNetLogObserver::Detach() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

if (instance_) {

// Safest not to do this in the destructor to maintain thread safety across

@@ -186,7 +186,7 @@ void DevToolsNetLogObserver::Detach() {

}

DevToolsNetLogObserver* DevToolsNetLogObserver::GetInstance() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

return instance_;

}