content/browser/appcache/chrome_appcache_service.cc - Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/chrome_appcache_service.cc

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_input_event_filter.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/chrome_appcache_service.cc

diff --git a/content/browser/appcache/chrome_appcache_service.cc b/content/browser/appcache/chrome_appcache_service.cc

index e4dbf7e00a1c61a1850d90109c6de91d28277768..c3cdf1634bd2132ad151b5f32a2ae6f05017c703 100644

--- a/content/browser/appcache/chrome_appcache_service.cc

+++ b/content/browser/appcache/chrome_appcache_service.cc

@@ -25,7 +25,7 @@ void ChromeAppCacheService::InitializeOnIOThread(

ResourceContext* resource_context,

net::URLRequestContextGetter* request_context_getter,

scoped_refptr<storage::SpecialStoragePolicy> special_storage_policy) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

cache_path_ = cache_path;

resource_context_ = resource_context;

@@ -51,7 +51,7 @@ void ChromeAppCacheService::InitializeOnIOThread(

bool ChromeAppCacheService::CanLoadAppCache(const GURL& manifest_url,

const GURL& first_party) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

// We don't prompt for read access.

return GetContentClient()->browser()->AllowAppCache(

manifest_url, first_party, resource_context_);

@@ -59,7 +59,7 @@ bool ChromeAppCacheService::CanLoadAppCache(const GURL& manifest_url,

bool ChromeAppCacheService::CanCreateAppCache(

const GURL& manifest_url, const GURL& first_party) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

return GetContentClient()->browser()->AllowAppCache(

manifest_url, first_party, resource_context_);

}