Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006953003: Revert "Remove spellcheck feedback." (Closed)

Created:
5 years, 9 months ago by please use gerrit instead
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, rouslan+spellwatch_chromium.org, mkwst+moarreviews-renderer_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org, darin-cc_chromium.org, jiongxi_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove spellcheck feedback." This re-enables spellcheck feedback by reverting commit http://crrev.com/60f701a, because the server is ready to process the feedback. BUG=466794 Committed: https://crrev.com/c9c5b39ae64108a5ee3a7b1bdbb63b0bab091a80 Cr-Commit-Position: refs/heads/master@{#322222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2320 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 5 chunks +16 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback.h View 1 chunk +112 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback_sender.h View 1 chunk +177 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback_sender.cc View 1 chunk +424 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback_sender_unittest.cc View 1 chunk +624 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/feedback_unittest.cc View 1 chunk +259 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/misspelling.h View 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/misspelling.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/misspelling_unittest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 4 chunks +22 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.h View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 4 chunks +29 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/word_trimmer.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/word_trimmer.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/word_trimmer_unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/common/spellcheck_messages.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/context_menu_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/context_menu_params.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/context_menu_params_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
please use gerrit instead
Rachel, PTAL.
5 years, 9 months ago (2015-03-17 16:11:05 UTC) #2
groby-ooo-7-16
RS LGTM, assuming this is a mechanical revert without additional edits.
5 years, 9 months ago (2015-03-17 17:40:00 UTC) #3
please use gerrit instead
inferno@chromium.org: Please review changes in chrome/common/spellcheck_messages.h content/common/frame_messages.h sievers@chromium.org: Please review changes in content/public/common/context_menu_params.h content/public/common/context_menu_params.cc content/renderer/context_menu_params_builder.cc ...
5 years, 9 months ago (2015-03-17 17:48:39 UTC) #5
lazyboy
render_context_menu/* LGTM.
5 years, 9 months ago (2015-03-17 17:53:17 UTC) #6
no sievers
content lgtm
5 years, 9 months ago (2015-03-18 23:33:04 UTC) #7
please use gerrit instead
ping inferno@
5 years, 9 months ago (2015-03-24 15:33:19 UTC) #8
please use gerrit instead
Tom, Please review changes in: chrome/common/spellcheck_messages.h content/common/frame_messages.h
5 years, 9 months ago (2015-03-24 20:26:35 UTC) #10
Tom Sepez
lgtm
5 years, 9 months ago (2015-03-24 20:30:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006953003/1
5 years, 9 months ago (2015-03-24 21:08:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/46756)
5 years, 9 months ago (2015-03-25 03:42:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006953003/1
5 years, 9 months ago (2015-03-25 19:24:55 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 19:59:05 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:59:46 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c9c5b39ae64108a5ee3a7b1bdbb63b0bab091a80
Cr-Commit-Position: refs/heads/master@{#322222}

Powered by Google App Engine
This is Rietveld 408576698