Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

Issue 1006953003: Revert "Remove spellcheck feedback." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/spelling_menu_observer.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
index 80dc0973dc4bacdc78a11a0845cf0029189c0325..7c37a8306d17a362be35799132826d73c5860125 100644
--- a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
@@ -37,6 +37,7 @@ SpellingMenuObserver::SpellingMenuObserver(RenderViewContextMenuProxy* proxy)
: proxy_(proxy),
loading_frame_(0),
succeeded_(false),
+ misspelling_hash_(0),
client_(new SpellingServiceClient) {
if (proxy_ && proxy_->GetBrowserContext()) {
Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
@@ -67,6 +68,7 @@ void SpellingMenuObserver::InitMenu(const content::ContextMenuParams& params) {
suggestions_ = params.dictionary_suggestions;
misspelled_word_ = params.misspelled_word;
+ misspelling_hash_ = params.misspelling_hash;
bool use_suggestions = SpellingServiceClient::IsAvailable(
browser_context, SpellingServiceClient::SUGGEST);
@@ -256,6 +258,8 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
if (spellcheck->GetMetrics())
spellcheck->GetMetrics()->RecordReplacedWordStats(1);
+ spellcheck->GetFeedbackSender()->SelectedSuggestion(
+ misspelling_hash_, suggestion_index);
}
}
return;
@@ -280,6 +284,7 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
spellcheck->GetCustomDictionary()->AddWord(base::UTF16ToUTF8(
misspelled_word_));
+ spellcheck->GetFeedbackSender()->AddedToDictionary(misspelling_hash_);
}
}
#if defined(OS_MACOSX)
@@ -342,6 +347,17 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
}
}
+void SpellingMenuObserver::OnMenuCancel() {
+ content::BrowserContext* browser_context = proxy_->GetBrowserContext();
+ if (!browser_context)
+ return;
+ SpellcheckService* spellcheck =
+ SpellcheckServiceFactory::GetForContext(browser_context);
+ if (!spellcheck)
+ return;
+ spellcheck->GetFeedbackSender()->IgnoredSuggestions(misspelling_hash_);
+}
+
void SpellingMenuObserver::OnTextCheckComplete(
SpellingServiceClient::ServiceType type,
bool success,
« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.h ('k') | chrome/browser/spellchecker/feedback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698