Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5336)

Unified Diff: chrome/browser/spellchecker/misspelling.cc

Issue 1006953003: Revert "Remove spellcheck feedback." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/misspelling.h ('k') | chrome/browser/spellchecker/misspelling_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/misspelling.cc
diff --git a/chrome/browser/spellchecker/misspelling.cc b/chrome/browser/spellchecker/misspelling.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e92a6f4ebb606ae6d8c976903242ea1ba200229d
--- /dev/null
+++ b/chrome/browser/spellchecker/misspelling.cc
@@ -0,0 +1,74 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// The |Misspelling| object stores the misspelling, a spellcheck suggestion for
+// it, and user's action on it. The misspelling is stored as |context|,
+// |location|, and |length| instead of only misspelled text, because the
+// spellcheck algorithm uses the context.
+
+#include "chrome/browser/spellchecker/misspelling.h"
+
+#include "base/strings/string_number_conversions.h"
+#include "base/values.h"
+
+namespace {
+
+// Builds a value from a list of spellcheck suggestions. The caller owns the
+// result.
+base::Value* BuildSuggestionsValue(const std::vector<base::string16>& list) {
+ base::ListValue* result = new base::ListValue;
+ result->AppendStrings(list);
+ return result;
+}
+
+// Builds a value from a spellcheck action. The caller owns the result.
+base::Value* BuildUserActionValue(const SpellcheckAction& action) {
+ base::ListValue* result = new base::ListValue;
+ result->Append(action.Serialize());
+ return result;
+}
+
+} // namespace
+
+Misspelling::Misspelling()
+ : location(0), length(0), hash(0), timestamp(base::Time::Now()) {
+}
+
+Misspelling::Misspelling(const base::string16& context,
+ size_t location,
+ size_t length,
+ const std::vector<base::string16>& suggestions,
+ uint32 hash)
+ : context(context),
+ location(location),
+ length(length),
+ suggestions(suggestions),
+ hash(hash),
+ timestamp(base::Time::Now()) {
+}
+
+Misspelling::~Misspelling() {
+}
+
+base::DictionaryValue* Misspelling::Serialize() const {
+ base::DictionaryValue* result = new base::DictionaryValue;
+ result->SetString(
+ "timestamp",
+ base::Int64ToString(static_cast<long>(timestamp.ToJsTime())));
+ result->SetInteger("misspelledLength", length);
+ result->SetInteger("misspelledStart", location);
+ result->SetString("originalText", context);
+ result->SetString("suggestionId", base::UintToString(hash));
+ result->Set("suggestions", BuildSuggestionsValue(suggestions));
+ result->Set("userActions", BuildUserActionValue(action));
+ return result;
+}
+
+base::string16 Misspelling::GetMisspelledString() const {
+ // Feedback sender does not create Misspelling objects for spellcheck results
+ // that are out-of-bounds of checked text length.
+ if (location > context.length())
+ return base::string16();
+ return context.substr(location, length);
+}
« no previous file with comments | « chrome/browser/spellchecker/misspelling.h ('k') | chrome/browser/spellchecker/misspelling_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698