Extensions: Switch to new permission message system, part III

Extensions: Switch to new permission message system, part III

Switch all callers over to the interim system

BUG=398257
Committed: https://crrev.com/7b45a34b0d0da16f07829b471d01d878ac170da2
Cr-Commit-Position: refs/heads/master@{#325415}

[Marc Treib, 2015-03-23 14:41:45]

treib@chromium.org changed reviewers:
+ sashab@chromium.org, yoz@chromium.org

[Marc Treib, 2015-03-23 14:41:46]

Next part - PTAL!

[Marc Treib, 2015-03-27 13:01:46]

Ping! :)

Also, since Yoyo is leaving: Can one of you recommend someone else to take over
reviewing this whole thing? Thanks!

[Yoyo Zhou, 2015-03-30 20:29:27]

LGTM. Sorry I didn't get to this earlier.

https://codereview.chromium.org/1004123003/diff/60001/extensions/common/permi...
File extensions/common/permissions/permission_message_provider.h (right):

https://codereview.chromium.org/1004123003/diff/60001/extensions/common/permi...
extensions/common/permissions/permission_message_provider.h:101: private:
Cool!

[Marc Treib, 2015-03-31 08:15:19]

treib@chromium.org changed reviewers:
+ finnur@chromium.org, rohitrao@chromium.org

[Marc Treib, 2015-03-31 08:15:19]

Adding OWNERS for approval:

rohitrao for
c/b/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

finnur for c/b/ui/views/extensions/extension_install_dialog_view_browsertest.cc

PTAL, thanks!

[Marc Treib, 2015-03-31 08:16:33]

On 2015/03/31 08:15:19, Marc Treib wrote:
> Adding OWNERS for approval:
> 
> rohitrao for
> c/b/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
> 
> finnur for
c/b/ui/views/extensions/extension_install_dialog_view_browsertest.cc
> 
> PTAL, thanks!

Also: Sasha, PTAL at app_info_permissions_panel.*!

[Finnur, 2015-03-31 11:19:42]

OWNERS LGTM.

[Marc Treib, 2015-04-07 08:36:49]

Ping:
rohitrao, please look at extension_install_view_controller_unittest.mm
sashab, please look at app_info_permissions_panel.h/cc

Thanks!

[rohitrao (ping after 24h), 2015-04-07 12:35:34]

cocoa/ LGTM

[Marc Treib, 2015-04-10 15:39:41]

Ping! Sasha, you still there? ;)

[Marc Treib, 2015-04-14 13:36:50]

treib@chromium.org changed reviewers:
+ tapted@chromium.org

[Marc Treib, 2015-04-14 13:36:51]

+tapted: Can you PTAL at app_info_permissions_panel.h/cc, since sashab (the only
"direct" owner) is unresponsive?
Thanks!

[sashab, 2015-04-14 23:21:22]

So sorry I've been unresponsive!! Been away, then sick, then super busy, then
away again... but this looks amazing!! So excited to see this coming together, I
love extensions::PermissionMessageStrings and this whole system is looking
fantastic. Job well done and a big LGTM from me. :D!

[Marc Treib, 2015-04-15 16:52:53]

Wow, thanks, and good to have you back!

tapted, since you're already here, can you approve the trivial change in
ephemeral_app_launcher.cc? Then this can finally land :)

[tapted, 2015-04-16 01:22:19]

ephemeral_app_launcher.cc lgtm!  Sorry - didn't realize I was still useful :p

[Marc Treib, 2015-04-16 08:02:07]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2015-04-16 08:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004123003/60001

[commit-bot: I haz the power, 2015-04-16 11:48:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-16 11:49:31]

Patchset 4 (id:??) landed as
https://crrev.com/7b45a34b0d0da16f07829b471d01d878ac170da2
Cr-Commit-Position: refs/heads/master@{#325415}