Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 1004123003: Extensions: Switch to new permission message system, part III (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_tests
Patch Set: Mac Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index 3fee044642ea6a1ed7b1ba158bd57694cd4a8a44..e0f9b107a3b567e15da6797fc053410263206275 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -138,19 +138,11 @@ class PermissionsData {
PermissionMessageIDs GetLegacyPermissionMessageIDs() const;
// Returns the full list of permission messages that should display at install
- // time as strings.
+ // time, including their submessages, as strings.
+ // TODO(treib): Remove this and move callers over to
+ // GetCoalescedPermissionMessages once we've fully switched to the new system.
PermissionMessageStrings GetPermissionMessageStrings() const;
- // Returns the full list of permission messages that should display at install
- // time as strings.
- // TODO(sashab): Deprecate this in favor of GetPermissionMessageStrings.
- std::vector<base::string16> GetLegacyPermissionMessageStrings() const;
-
- // Returns the full list of permission details for messages that should
- // display at install time as strings.
- // TODO(sashab): Deprecate this in favor of GetPermissionMessageStrings.
- std::vector<base::string16> GetLegacyPermissionMessageDetailsStrings() const;
-
// Returns the full list of permission details for messages that should
// display at install time, in a nested format ready for display.
CoalescedPermissionMessages GetCoalescedPermissionMessages() const;

Powered by Google App Engine
This is Rietveld 408576698