Extensions: Switch to new permission message system, part III

extensions/common/permissions/permission_message_provider.h

Index: extensions/common/permissions/permission_message_provider.h
diff --git a/extensions/common/permissions/permission_message_provider.h b/extensions/common/permissions/permission_message_provider.h
index 3b8e5aca9f2531c2174ab3275318833668c31287..ca11ab37b20729026bc5b578b1f6e00f03c35e62 100644
--- a/extensions/common/permissions/permission_message_provider.h
+++ b/extensions/common/permissions/permission_message_provider.h
@@ -78,25 +78,6 @@ class PermissionMessageProvider {
   virtual CoalescedPermissionMessages GetCoalescedPermissionMessages(
       const PermissionIDSet& permissions) const = 0;
 
-  // Gets the localized permission messages that represent this set (represented
-  // as strings). The set of permission messages shown varies by extension type.
-  // Any permissions added by API, host or manifest permissions need to be added
-  // to |permissions| before this function is called.
-  // Deprecated; use GetPermissionMessageStrings instead.
-  // TODO(treib): Remove this once we've switched to the new system.
-  virtual std::vector<base::string16> GetLegacyWarningMessages(
-      const PermissionSet* permissions,
-      Manifest::Type extension_type) const = 0;
-
-  // Gets the localized permission details for messages that represent this set
-  // (represented as strings). The set of permission messages shown varies by
-  // extension type.
-  // Deprecated; use GetPermissionMessageStrings instead.
-  // TODO(treib): Remove this once we've switched to the new system.
-  virtual std::vector<base::string16> GetLegacyWarningMessagesDetails(
-      const PermissionSet* permissions,
-      Manifest::Type extension_type) const = 0;
-
   // Returns true if |new_permissions| has a greater privilege level than
   // |old_permissions|.
   // Whether certain permissions are considered varies by extension type.
@@ -116,6 +97,26 @@ class PermissionMessageProvider {
   virtual PermissionIDSet GetAllPermissionIDs(
       const PermissionSet* permissions,
       Manifest::Type extension_type) const = 0;
+
+ private:

[Yoyo Zhou, 2015/03/30 20:29:27]

Cool!

+  // Gets the localized permission messages that represent this set (represented
+  // as strings). The set of permission messages shown varies by extension type.
+  // Any permissions added by API, host or manifest permissions need to be added
+  // to |permissions| before this function is called.
+  // Deprecated; use GetPermissionMessageStrings instead.
+  // TODO(treib): Remove this once we've switched to the new system.
+  virtual std::vector<base::string16> GetLegacyWarningMessages(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const = 0;
+
+  // Gets the localized permission details for messages that represent this set
+  // (represented as strings). The set of permission messages shown varies by
+  // extension type.
+  // Deprecated; use GetPermissionMessageStrings instead.
+  // TODO(treib): Remove this once we've switched to the new system.
+  virtual std::vector<base::string16> GetLegacyWarningMessagesDetails(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const = 0;
 };
 
 }  // namespace extensions