Extensions: Switch to new permission message system, part III

extensions/common/permissions/permissions_data.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 120 matching lines @@
   // permission that effectively grants access to all hosts (e.g. proxy,
   // network, etc.)
   bool HasEffectiveAccessToAllHosts() const;
 
   // Returns the full list of legacy permission message IDs.
   // Deprecated. You DO NOT want to call this!
   // TODO(treib): Remove once we've switched to the new system.
   PermissionMessageIDs GetLegacyPermissionMessageIDs() const;
 
   // Returns the full list of permission messages that should display at install
-  // time as strings.
+  // time, including their submessages, as strings.
+  // TODO(treib): Remove this and move callers over to
+  // GetCoalescedPermissionMessages once we've fully switched to the new system.
   PermissionMessageStrings GetPermissionMessageStrings() const;
 
-  // Returns the full list of permission messages that should display at install
-  // time as strings.
-  // TODO(sashab): Deprecate this in favor of GetPermissionMessageStrings.
-  std::vector<base::string16> GetLegacyPermissionMessageStrings() const;
-
-  // Returns the full list of permission details for messages that should
-  // display at install time as strings.
-  // TODO(sashab): Deprecate this in favor of GetPermissionMessageStrings.
-  std::vector<base::string16> GetLegacyPermissionMessageDetailsStrings() const;
-
   // Returns the full list of permission details for messages that should
   // display at install time, in a nested format ready for display.
   CoalescedPermissionMessages GetCoalescedPermissionMessages() const;
 
   // Returns true if the extension has requested all-hosts permissions (or
   // something close to it), but has had it withheld.
   bool HasWithheldImpliedAllHosts() const;
 
   // Returns true if the |extension| has permission to access and interact with
   // the specified page, in order to do things like inject scripts or modify
@@ skipping 118 matching lines @@
   mutable scoped_refptr<const PermissionSet> withheld_permissions_unsafe_;
 
   mutable TabPermissionsMap tab_specific_permissions_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionsData);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_