chrome/browser/extensions/extension_install_prompt.h - Issue 1004123003: Extensions: Switch to new permission message system, part III

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 1004123003: Extensions: Switch to new permission message system, part III (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_tests

Patch Set: Mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | extensions/common/permissions/permission_message_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_prompt.h

diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h

index 56b774c7827da551acb7df0c95d464b44f175b3f..7387ff18e31d988701f6d3346efa86ab19389927 100644

--- a/chrome/browser/extensions/extension_install_prompt.h

+++ b/chrome/browser/extensions/extension_install_prompt.h

@@ -15,6 +15,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string16.h"

+#include "extensions/common/permissions/permission_message_provider.h"

#include "extensions/common/url_pattern.h"

#include "third_party/skia/include/core/SkBitmap.h"

#include "ui/gfx/image/image.h"

@@ -109,12 +110,8 @@ class ExtensionInstallPrompt

public:

explicit Prompt(PromptType type);

- // Sets the permission list for this prompt.

- void SetPermissions(const std::vector<base::string16>& permissions,

+ void SetPermissions(const extensions::PermissionMessageStrings& permissions,

PermissionsType permissions_type);

- // Sets the permission list details for this prompt.

- void SetPermissionsDetails(const std::vector<base::string16>& details,

- PermissionsType permissions_type);

void SetIsShowingDetails(DetailsType type,

size_t index,

bool is_showing_details);