Issue 882093002: Align process implementation and fix bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882093002: Align process implementation and fix bugs (Closed)

Created:
5 years, 10 months ago by Søren Gjesse

Modified:
5 years, 10 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Aling process implementation and fix bugs Aling the code for dart:io process as much as possible between Linux, Mac OS and Android prior to refactiring the code. On Mac OS file descriptors where not closed corrently. On Linux EINTR was not expected for all calls. R=kustermann@google.com, kunstemann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43274

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	runtime/bin/process_android.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

LGTM - though I'm not sure if chdir/kill/... are interruptable syscalls (though I guess it ...

5 years, 10 months ago (2015-01-29 11:27:25 UTC) #4

Søren Gjesse

On 2015/01/29 11:27:25, kustermann wrote: > LGTM - though I'm not sure if chdir/kill/... are ...

5 years, 10 months ago (2015-01-29 11:34:39 UTC) #5

Søren Gjesse

5 years, 10 months ago (2015-01-29 11:55:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43274 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages