Align process implementation and fix bugs

runtime/bin/process_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include "bin/process.h"
 
 #include <errno.h>  // NOLINT
@@ skipping 358 matching lines @@
   }
 
   pid = TEMP_FAILURE_RETRY(fork());
   if (pid < 0) {
     SetChildOsErrorMessage(os_error_message);
     delete[] program_arguments;
     VOID_TEMP_FAILURE_RETRY(close(exec_control[0]));
     VOID_TEMP_FAILURE_RETRY(close(exec_control[1]));
     VOID_TEMP_FAILURE_RETRY(close(read_in[0]));
     VOID_TEMP_FAILURE_RETRY(close(read_in[1]));
-    if (detach) {
+    if (!detach) {
       VOID_TEMP_FAILURE_RETRY(close(read_err[0]));
       VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
       VOID_TEMP_FAILURE_RETRY(close(write_out[0]));
       VOID_TEMP_FAILURE_RETRY(close(write_out[1]));
     }
     return errno;
   } else if (pid == 0) {
     // Wait for parent process before setting up the child process.
     char msg;
     int bytes_read = FDUtils::ReadFromBlocking(read_in[0], &msg, sizeof(msg));
@@ skipping 124 matching lines @@
     FDUtils::SetNonBlocking(event_fds[0]);
   }
 
   // Notify child process to start.
   char msg = '1';
   result = FDUtils::WriteToBlocking(read_in[1], &msg, sizeof(msg));
   if (result != sizeof(msg)) {
     perror("Failed sending notification message");
   }
 
-  // Read exec result from child. If no data is returned the exec was
-  // successful and the exec call closed the pipe. Otherwise the errno
-  // is written to the pipe.
   VOID_TEMP_FAILURE_RETRY(close(exec_control[1]));
   bool failed = false;
   int child_errno;
   int bytes_read = -1;
   ASSERT(sizeof(child_errno) == sizeof(errno));
   if (!detach) {
     // Read exec result from child. If no data is returned the exec was
     // successful and the exec call closed the pipe. Otherwise the errno
     // is written to the pipe.
     bytes_read =
@@ skipping 348 matching lines @@
     bzero(&act, sizeof(act));
     act.sa_handler = SIG_DFL;
     VOID_NO_RETRY_EXPECTED(sigaction(signal, &act, NULL));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)