Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: runtime/bin/process_macos.cc

Issue 882093002: Align process implementation and fix bugs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_macos.cc
diff --git a/runtime/bin/process_macos.cc b/runtime/bin/process_macos.cc
index a6d9301b421cd5f83e0224e7135908aa873f9d50..f71b258ce920c7f0a1af9e504d039440a3a9bd38 100644
--- a/runtime/bin/process_macos.cc
+++ b/runtime/bin/process_macos.cc
@@ -376,7 +376,7 @@ int Process::Start(const char* path,
VOID_TEMP_FAILURE_RETRY(close(exec_control[1]));
VOID_TEMP_FAILURE_RETRY(close(read_in[0]));
VOID_TEMP_FAILURE_RETRY(close(read_in[1]));
- if (detach) {
+ if (!detach) {
VOID_TEMP_FAILURE_RETRY(close(read_err[0]));
VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
VOID_TEMP_FAILURE_RETRY(close(write_out[0]));
@@ -521,9 +521,6 @@ int Process::Start(const char* path,
perror("Failed sending notification message");
}
- // Read exec result from child. If no data is returned the exec was
- // successful and the exec call closed the pipe. Otherwise the errno
- // is written to the pipe.
VOID_TEMP_FAILURE_RETRY(close(exec_control[1]));
bool failed = false;
int child_errno;
« no previous file with comments | « runtime/bin/process_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698