Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: runtime/bin/process_linux.cc

Issue 882093002: Align process implementation and fix bugs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_android.cc ('k') | runtime/bin/process_macos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_linux.cc
diff --git a/runtime/bin/process_linux.cc b/runtime/bin/process_linux.cc
index 3b56f0a6ef9e1032e40a4334f0528dd4c313e2ea..f3665721b4e71c3e75d938c773247f5914e245de 100644
--- a/runtime/bin/process_linux.cc
+++ b/runtime/bin/process_linux.cc
@@ -466,7 +466,8 @@ int Process::Start(const char* path,
}
VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
- if (working_directory != NULL && chdir(working_directory) == -1) {
+ if (working_directory != NULL &&
+ TEMP_FAILURE_RETRY(chdir(working_directory)) == -1) {
ReportChildError(exec_control[1]);
}
@@ -491,7 +492,7 @@ int Process::Start(const char* path,
if (!detach) {
int event_fds[2];
- result = pipe(event_fds);
+ result = TEMP_FAILURE_RETRY(pipe(event_fds));
if (result < 0) {
SetChildOsErrorMessage(os_error_message);
VOID_TEMP_FAILURE_RETRY(close(read_in[0]));
@@ -711,7 +712,7 @@ bool Process::Wait(intptr_t pid,
bool Process::Kill(intptr_t id, int signal) {
- return kill(id, signal) != -1;
+ return (TEMP_FAILURE_RETRY(kill(id, signal)) != -1);
}
« no previous file with comments | « runtime/bin/process_android.cc ('k') | runtime/bin/process_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698