Align process implementation and fix bugs

runtime/bin/process_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/process.h"
 
 #include <errno.h>  // NOLINT
@@ skipping 450 matching lines @@
       if (TEMP_FAILURE_RETRY(dup2(read_in[1], STDOUT_FILENO)) == -1) {
         ReportChildError(exec_control[1]);
       }
       VOID_TEMP_FAILURE_RETRY(close(read_in[1]));
 
       if (TEMP_FAILURE_RETRY(dup2(read_err[1], STDERR_FILENO)) == -1) {
         ReportChildError(exec_control[1]);
       }
       VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
 
-      if (working_directory != NULL && chdir(working_directory) == -1) {
+      if (working_directory != NULL &&
+          TEMP_FAILURE_RETRY(chdir(working_directory)) == -1) {
         ReportChildError(exec_control[1]);
       }
 
       if (program_environment != NULL) {
         environ = program_environment;
       }
 
       VOID_TEMP_FAILURE_RETRY(
           execvp(path, const_cast<char* const*>(program_arguments)));
 
       ReportChildError(exec_control[1]);
     }
   }
 
   // Be sure to listen for exit-codes, now we have a child-process.
   ExitCodeHandler::ProcessStarted();
 
   // The arguments and environment for the spawned process are not needed
   // any longer.
   delete[] program_arguments;
   delete[] program_environment;
 
   if (!detach) {
     int event_fds[2];
-    result = pipe(event_fds);
+    result = TEMP_FAILURE_RETRY(pipe(event_fds));
     if (result < 0) {
       SetChildOsErrorMessage(os_error_message);
       VOID_TEMP_FAILURE_RETRY(close(read_in[0]));
       VOID_TEMP_FAILURE_RETRY(close(read_in[1]));
       VOID_TEMP_FAILURE_RETRY(close(read_err[0]));
       VOID_TEMP_FAILURE_RETRY(close(read_err[1]));
       VOID_TEMP_FAILURE_RETRY(close(write_out[0]));
       VOID_TEMP_FAILURE_RETRY(close(write_out[1]));
       Log::PrintErr("Error pipe creation failed: %s\n", *os_error_message);
       return errno;
@@ skipping 326 matching lines @@
     bzero(&act, sizeof(act));
     act.sa_handler = SIG_DFL;
     VOID_NO_RETRY_EXPECTED(sigaction(signal, &act, NULL));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)