Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the

Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the (Closed)

Created:
7 years, 1 month ago by regis

Modified:
7 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Distinguish between malformed and malbounded types more efficiently using the recently introduced LanguageError 'kind' field. Got error on commit. Committed as r30383.

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -199 lines)			Patch
M	runtime/vm/ast.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	12 chunks	+47 lines, -30 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	7 chunks	+15 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+54 lines, -66 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	9 chunks	+32 lines, -58 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://codereview.chromium.org/75713002/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/75713002/diff/1/runtime/vm/class_finalizer.cc#newcode289 runtime/vm/class_finalizer.cc:289: if (type.IsMalformed() || type.IsMalbounded()) { Could you use ...

7 years, 1 month ago (2013-11-18 22:19:44 UTC) #2

regis

7 years, 1 month ago (2013-11-18 23:24:39 UTC) #3

Thanks!

https://codereview.chromium.org/75713002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/75713002/diff/1/runtime/vm/class_finalizer.cc...
runtime/vm/class_finalizer.cc:289: if (type.IsMalformed() ||
type.IsMalbounded()) {
On 2013/11/18 22:19:44, hausner wrote:
> Could you use IsMalformedOrMalbounded() here?
> 
> Or asked in a different way, is it worth having IsMalformedOrMalbounded if you
> get the same result by using the simple or-expression above.

Good point. I used the combined call, because it saves a handle creation
compared to calling both.

I also replaced many other such patterns.

Expand Messages | Collapse Messages