runtime/vm/flow_graph_optimizer.cc - Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 30381)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -3000,7 +3000,7 @@

RawBool* FlowGraphOptimizer::InstanceOfAsBool(const ICData& ic_data,

const AbstractType& type) const {

ASSERT(ic_data.num_args_tested() == 1); // Unary checks only.

- if (!type.IsInstantiated() || type.IsMalformed() || type.IsMalbounded()) {

+ if (!type.IsInstantiated() || type.IsMalformedOrMalbounded()) {

return Bool::null();

}

const Class& type_class = Class::Handle(type.type_class());

@@ -3098,7 +3098,7 @@

Definition* type_args = call->ArgumentAt(2);

const AbstractType& type =

AbstractType::Cast(call->ArgumentAt(3)->AsConstant()->value());

- ASSERT(!type.IsMalformed() && !type.IsMalbounded());

+ ASSERT(!type.IsMalformedOrMalbounded());

const ICData& unary_checks =

ICData::ZoneHandle(call->ic_data()->AsUnaryClassChecks());

if (unary_checks.NumberOfChecks() <= FLAG_max_polymorphic_checks) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »