Distinguish between malformed and malbounded types more efficiently using the

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 655 matching lines @@
 DEFINE_RUNTIME_ENTRY(BadTypeError, 3) {
   const intptr_t location = GetCallerLocation();
   const Instance& src_value = Instance::CheckedHandle(arguments.ArgAt(0));
   const String& dst_name = String::CheckedHandle(arguments.ArgAt(1));
   const AbstractType& dst_type =
       AbstractType::CheckedHandle(arguments.ArgAt(2));
   const AbstractType& src_type = AbstractType::Handle(src_value.GetType());
   const String& src_type_name = String::Handle(src_type.UserVisibleName());
 
   String& dst_type_name = String::Handle();
-  Error& error = Error::Handle();
-  if (dst_type.IsMalformed()) {
-    error = dst_type.malformed_error();
+  LanguageError& error = LanguageError::Handle(dst_type.error());
+  ASSERT(!error.IsNull());
+  if (error.kind() == LanguageError::kMalformedType) {
     dst_type_name = Symbols::Malformed().raw();
   } else {
-    const bool is_malbounded = dst_type.IsMalboundedWithError(&error);
+    ASSERT(error.kind() == LanguageError::kMalboundedType);
     dst_type_name = Symbols::Malbounded().raw();
-    ASSERT(is_malbounded);
   }
   const String& error_message = String::ZoneHandle(
       Symbols::New(error.ToErrorCString()));
   Exceptions::CreateAndThrowTypeError(
       location, src_type_name, dst_type_name, dst_name, error_message);
   UNREACHABLE();
 }
 
 
 DEFINE_RUNTIME_ENTRY(Throw, 1) {
@@ skipping 1005 matching lines @@
 // of the given value.
 //   Arg0: Field object;
 //   Arg1: Value that is being stored.
 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   const Object& value = Object::Handle(arguments.ArgAt(1));
   field.UpdateGuardedCidAndLength(value);
 }
 
 }  // namespace dart