Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: runtime/vm/code_generator.cc

Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 30381)
+++ runtime/vm/code_generator.cc (working copy)
@@ -673,14 +673,13 @@
const String& src_type_name = String::Handle(src_type.UserVisibleName());
String& dst_type_name = String::Handle();
- Error& error = Error::Handle();
- if (dst_type.IsMalformed()) {
- error = dst_type.malformed_error();
+ LanguageError& error = LanguageError::Handle(dst_type.error());
+ ASSERT(!error.IsNull());
+ if (error.kind() == LanguageError::kMalformedType) {
dst_type_name = Symbols::Malformed().raw();
} else {
- const bool is_malbounded = dst_type.IsMalboundedWithError(&error);
+ ASSERT(error.kind() == LanguageError::kMalboundedType);
dst_type_name = Symbols::Malbounded().raw();
- ASSERT(is_malbounded);
}
const String& error_message = String::ZoneHandle(
Symbols::New(error.ToErrorCString()));
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698