Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: runtime/vm/class_finalizer.h

Issue 75713002: Distinguish between malformed and malbounded types more efficiently using the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.h
===================================================================
--- runtime/vm/class_finalizer.h (revision 30381)
+++ runtime/vm/class_finalizer.h (working copy)
@@ -57,8 +57,7 @@
const char* format, ...)
PRINTF_ATTRIBUTE(4, 5);
- // Depending on the given type, finalization mode, and execution mode, mark
- // the given type as malformed or report a compile time error.
+ // Mark the given type as malformed.
// If not null, prepend prev_error to the error message built from the format
// string and its arguments.
static void FinalizeMalformedType(const Error& prev_error,
@@ -67,6 +66,15 @@
const char* format, ...)
PRINTF_ATTRIBUTE(4, 5);
+ // Mark the given type as malbounded.
+ // If not null, prepend prev_error to the error message built from the format
+ // string and its arguments.
+ static void FinalizeMalboundedType(const Error& prev_error,
+ const Script& script,
+ const Type& type,
+ const char* format, ...)
+ PRINTF_ATTRIBUTE(4, 5);
+
// Return false if we still have classes pending to be finalized.
static bool AllClassesFinalized();
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698