Issue 68493003: Ensure that errors have stack traces attached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68493003: Ensure that errors have stack traces attached. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Ensure that errors have stack traces attached. This adds a stack trace argument to all [completeError] and [addError] calls in pub and associated libraries. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30332

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -49 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/serialize.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/http/lib/src/utils.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/http/test/safe_http_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/future_group.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/utils.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/server.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/io.dart	View	5 chunks	+20 lines, -20 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/safe_http_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	3 chunks	+5 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

7 years, 1 month ago (2013-11-16 01:19:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30332 (presubmit successful).