Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback.dart

Issue 68493003: Ensure that errors have stack traces attached. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/test/utils.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback.dart b/sdk/lib/_internal/pub/lib/src/barback.dart
index 52b97794cb3877d99df080e3405cb72bd9318367..08e5665232481ac2e23763cbcec884e94db7f0e7 100644
--- a/sdk/lib/_internal/pub/lib/src/barback.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback.dart
@@ -8,6 +8,7 @@ import 'dart:async';
import 'package:barback/barback.dart';
import 'package:path/path.dart' as path;
+import 'package:stack_trace/stack_trace.dart';
import 'barback/load_all_transformers.dart';
import 'barback/pub_package_provider.dart';
@@ -133,7 +134,9 @@ Future<BarbackServer> createServer(String host, int port, PackageGraph graph,
var subscriptions = [
server.barback.errors.listen((error) {
if (error is TransformerException) error = error.error;
- if (!completer.isCompleted) completer.completeError(error);
+ if (!completer.isCompleted) {
+ completer.completeError(error, new Trace.current());
+ }
}),
server.barback.results.listen((_) {}, onError: (error, stackTrace) {
if (completer.isCompleted) return;
« no previous file with comments | « pkg/scheduled_test/test/utils.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698