Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: pkg/barback/lib/src/serialize.dart

Issue 68493003: Ensure that errors have stack traces attached. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/asset_cascade.dart ('k') | pkg/http/lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/serialize.dart
diff --git a/pkg/barback/lib/src/serialize.dart b/pkg/barback/lib/src/serialize.dart
index eb948a451fe7ad68c1a5d551fa1138f16998dd59..fa5adeaba5d2f1fb069004e376ad1aabcf2ca314 100644
--- a/pkg/barback/lib/src/serialize.dart
+++ b/pkg/barback/lib/src/serialize.dart
@@ -61,7 +61,8 @@ StreamSubscription _deserializeTransformer(Stream input, bool cancelOnError) {
if (data['type'] == 'data') {
sink.add(data['data']);
} else if (data['type'] == 'error') {
- sink.addError(new CrossIsolateException.deserialize(data['error']));
+ var exception = new CrossIsolateException.deserialize(data['error']);
+ sink.addError(exception, exception.stackTrace);
} else {
assert(data['type'] == 'done');
sink.close();
« no previous file with comments | « pkg/barback/lib/src/asset_cascade.dart ('k') | pkg/http/lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698