pkg/http/lib/src/utils.dart - Issue 68493003: Ensure that errors have stack traces attached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/http/lib/src/utils.dart

Issue 68493003: Ensure that errors have stack traces attached. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/http/lib/src/utils.dart

diff --git a/pkg/http/lib/src/utils.dart b/pkg/http/lib/src/utils.dart

index dd3547d54926e1c4ce7f09363084e58379405cd6..cc39d45a137489c5deac40640ae96ba1f86975ce 100644

--- a/pkg/http/lib/src/utils.dart

+++ b/pkg/http/lib/src/utils.dart

@@ -216,9 +216,7 @@ class Pair<E, F> {

/// Configures [future] so that its result (success or exception) is passed on

/// to [completer].

void chainToCompleter(Future future, Completer completer) {

- future.then((v) => completer.complete(v)).catchError((error) {

- completer.completeError(error);

- });

+ future.then(completer.complete, onError: completer.completeError);

}

// TOOD(nweiz): Get rid of this once https://codereview.chromium.org/11293132/

« no previous file with comments | « pkg/barback/lib/src/serialize.dart ('k') | pkg/http/test/safe_http_server.dart » ('j') | no next file with comments »