pkg/scheduled_test/lib/src/future_group.dart - Issue 68493003: Ensure that errors have stack traces attached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/future_group.dart

Issue 68493003: Ensure that errors have stack traces attached. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/scheduled_test/lib/src/future_group.dart

diff --git a/pkg/scheduled_test/lib/src/future_group.dart b/pkg/scheduled_test/lib/src/future_group.dart

index f1f64db746c98748d47768ee3bfd160bd1d9e256..05071c84e031e5fbd9ad6530ab5de5686fc1b132 100644

--- a/pkg/scheduled_test/lib/src/future_group.dart

+++ b/pkg/scheduled_test/lib/src/future_group.dart

@@ -34,11 +34,11 @@ class FutureGroup<T> {

completed = true;

_completer.complete(_values);

}

- }).catchError((error) {

+ }).catchError((error, stackTrace) {

if (completed) return;

completed = true;

- _completer.completeError(error);

+ _completer.completeError(error, stackTrace);

}));

return task;