Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 678193004: Copy irregexp related code from V8. (Closed)

Created:
6 years, 1 month ago by zerny-google
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Copy irregexp related code from V8. This "syntactic" change copies the irregexp code from V8 r24065 to Dart. Compared to the V8 files the only changes are that the files have been suitably renamed, headers and footers have been updated, and most of the unneeded code has been replaced by a 'SNIP' marker. None of the files are added to the build and they cannot compile. Integration with the Dart VM is done in a follow-up CL [1]. [1]: https://codereview.chromium.org/683433003/ BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41455

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12508 lines, -6 lines) Patch
A runtime/vm/regexp.h View 1 chunk +1466 lines, -0 lines 0 comments Download
A runtime/vm/regexp.cc View 1 chunk +5438 lines, -0 lines 0 comments Download
A runtime/vm/regexp_assembler.h View 1 chunk +167 lines, -0 lines 0 comments Download
A + runtime/vm/regexp_assembler.cc View 1 chunk +13 lines, -6 lines 0 comments Download
A runtime/vm/regexp_ast.h View 1 chunk +386 lines, -0 lines 0 comments Download
A runtime/vm/regexp_ast.cc View 1 chunk +336 lines, -0 lines 0 comments Download
A runtime/vm/regexp_parser.h View 1 chunk +178 lines, -0 lines 0 comments Download
A runtime/vm/regexp_parser.cc View 1 chunk +1003 lines, -0 lines 0 comments Download
A runtime/vm/unibrow.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
A runtime/vm/unibrow.cc View 1 chunk +3393 lines, -0 lines 0 comments Download
A runtime/vm/unibrow-inl.h View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zerny-google
6 years, 1 month ago (2014-10-28 08:34:16 UTC) #2
Ivan Posva
LGTM Let's land this so we have a good overview of the changes needed in ...
6 years, 1 month ago (2014-11-03 08:44:43 UTC) #3
zerny-google
6 years, 1 month ago (2014-11-03 10:00:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41455.

Powered by Google App Engine
This is Rietveld 408576698