Remove isolate pointer from context objects.

Remove isolate pointer from context objects.

By moving all stubs that do runtime calls into the isolate
we don't need to cache the current isolate in each context
object.

This saves space on each context at the cost of duplicating stubs
in each isolate. Most stubs are already isolate-specific and the total number
 of stubs is small enough for this to be a good trade-off.

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41279

[Florian Schneider, 2014-10-22 14:36:35]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-10-22 15:45:45]

lgtm

https://codereview.chromium.org/668193002/diff/1/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

https://codereview.chromium.org/668193002/diff/1/runtime/vm/stub_code.cc#newc...
runtime/vm/stub_code.cc:68: void StubCode::GenerateOtherStubsFor(Isolate* init)
{
I find the name "other-stubs" confusing.

[Florian Schneider, 2014-10-22 16:28:20]

I need to fix an assertion failure with the constant pool for the assembler of
the bootstrap stubs on x64/ARM64. Those stubs don't use the constant pool, so
they should not allocate one in the first place.

[Florian Schneider, 2014-10-22 17:57:52]

All stubs that call into runtime are per-isolate. In order to be able to
generate the initial per-isolate stubs, I choose to split Object::Init into two
phases:

1. Registering and setting up the classes in the object store. This is needed
because the stub-assembler wants to allocate arrays and strings (e.g. object
pool, comments)

2. Loading bootstrap scripts and the rest: This needs to have the
LazyCompile-stub generated in order to initialize Function objects.

[Vyacheslav Egorov (Google), 2014-10-24 10:58:08]

lgtm with InitBootstrapStubs moved into Object::Init* 

I would like Ivan or Siva to check this cause it involves initialization order.

https://codereview.chromium.org/668193002/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/668193002/diff/40001/runtime/vm/dart.cc#newco...
runtime/vm/dart.cc:212: StubCode::InitBootstrapStubs(isolate);
Why don't you move this into Object::Init?

[Florian Schneider, 2014-10-24 11:24:39]

https://codereview.chromium.org/668193002/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/668193002/diff/40001/runtime/vm/dart.cc#newco...
runtime/vm/dart.cc:212: StubCode::InitBootstrapStubs(isolate);
On 2014/10/24 10:58:08, Vyacheslav Egorov (Google) wrote:
> Why don't you move this into Object::Init?

Done.

[Florian Schneider, 2014-10-24 12:19:42]

Committed patchset #5 (id:80001) manually as r41279 (presubmit successful).