Remove isolate pointer from context objects.

runtime/vm/dart.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart.h"
 
 #include "vm/code_observers.h"
 #include "vm/cpu.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
@@ skipping 186 matching lines @@
   Heap::Init(isolate,
              FLAG_new_gen_semi_max_size * MBInWords,
              FLAG_old_gen_heap_size * MBInWords);
   ObjectIdRing::Init(isolate);
   ObjectStore::Init(isolate);
 
   // Setup for profiling.
   Profiler::InitProfilingForIsolate(isolate);
 
   if (snapshot_buffer == NULL) {
-    const Error& error = Error::Handle(Object::Init(isolate));
+    Error& error = Error::Handle(Object::Init(isolate));
+    if (!error.IsNull()) {
+      return error.raw();
+    }
+
+    StubCode::InitBootstrapStubs(isolate);

[Vyacheslav Egorov (Google), 2014/10/24 10:58:08]

Why don't you move this into Object::Init?

[Florian Schneider, 2014/10/24 11:24:39]

Done.

+
+    error = Object::FinishInit(isolate);
     if (!error.IsNull()) {
       return error.raw();
     }
   } else {
     // Initialize from snapshot (this should replicate the functionality
     // of Object::Init(..) in a regular isolate creation path.
     Object::InitFromSnapshot(isolate);
 
+    StubCode::InitBootstrapStubs(isolate);
+
     // TODO(turnidge): Remove once length is not part of the snapshot.
     const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer);
     if (snapshot == NULL) {
       const String& message = String::Handle(
           String::New("Invalid snapshot."));
       return ApiError::New(message);
     }
     ASSERT(snapshot->kind() == Snapshot::kFull);
     if (FLAG_trace_isolates) {
       OS::Print("Size of isolate snapshot = %" Pd "\n", snapshot->length());
@@ skipping 64 matching lines @@
   return predefined_handles_->handles_.AllocateScopedHandle();
 }
 
 
 bool Dart::IsReadOnlyHandle(uword address) {
   ASSERT(predefined_handles_ != NULL);
   return predefined_handles_->handles_.IsValidScopedHandle(address);
 }
 
 }  // namespace dart