Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 668193002: Remove isolate pointer from context objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm_test.cc ('k') | runtime/vm/stub_code_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 41244)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -47,8 +47,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into EAX.
- __ movl(EAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(EAX);
// Save exit frame information to enable stack walking as we are about
// to transition to Dart VM C++ code.
@@ -168,8 +167,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into EDI.
- __ movl(EDI, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(EDI);
// Save exit frame information to enable stack walking as we are about
// to transition to dart VM code.
@@ -273,8 +271,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into EDI.
- __ movl(EDI, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(EDI);
// Save exit frame information to enable stack walking as we are about
// to transition to dart VM code.
@@ -995,13 +992,6 @@
// EDX: number of context variables as integer value (not object).
__ movl(FieldAddress(EAX, Context::num_variables_offset()), EDX);
- // Setup isolate field.
- // Load Isolate pointer from Context structure into EBX.
- // EAX: new object.
- // EDX: number of context variables.
- __ movl(FieldAddress(EAX, Context::isolate_offset()),
- Immediate(reinterpret_cast<int32_t>(isolate)));
-
const Immediate& raw_null =
Immediate(reinterpret_cast<intptr_t>(Object::null()));
// Setup the parent field.
@@ -1794,7 +1784,7 @@
void StubCode::GenerateDebugStepCheckStub(Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ movl(EAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(EAX);
__ movzxb(EAX, Address(EAX, Isolate::single_step_offset()));
__ cmpl(EAX, Immediate(0));
__ j(NOT_EQUAL, &stepping, Assembler::kNearJump);
@@ -2056,7 +2046,7 @@
Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ movl(EAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(EAX);
__ movzxb(EAX, Address(EAX, Isolate::single_step_offset()));
__ cmpl(EAX, Immediate(0));
__ j(NOT_EQUAL, &stepping);
« no previous file with comments | « runtime/vm/stub_code_arm_test.cc ('k') | runtime/vm/stub_code_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698