Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 668193002: Remove isolate pointer from context objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_mips_test.cc ('k') | runtime/vm/stub_code_x64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
===================================================================
--- runtime/vm/stub_code_x64.cc (revision 41244)
+++ runtime/vm/stub_code_x64.cc (working copy)
@@ -44,8 +44,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into RAX.
- __ movq(RAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(RAX);
// Save exit frame information to enable stack walking as we are about
// to transition to Dart VM C++ code.
@@ -156,8 +155,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into R8.
- __ movq(R8, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(R8);
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
@@ -245,8 +243,7 @@
__ EnterFrame(0);
- // Load current Isolate pointer from Context structure into R8.
- __ movq(R8, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(R8);
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
@@ -979,13 +976,6 @@
// R10: number of context variables as integer value (not object).
__ movq(FieldAddress(RAX, Context::num_variables_offset()), R10);
- // Setup isolate field.
- // RAX: new object.
- // R10: number of context variables.
- // R13: Isolate, not an object.
- __ LoadIsolate(R13);
- __ movq(FieldAddress(RAX, Context::isolate_offset()), R13);
-
// Setup the parent field.
// RAX: new object.
// R10: number of context variables.
@@ -1754,7 +1744,7 @@
void StubCode::GenerateDebugStepCheckStub(Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ movq(RAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(RAX);
__ movzxb(RAX, Address(RAX, Isolate::single_step_offset()));
__ cmpq(RAX, Immediate(0));
__ j(NOT_EQUAL, &stepping, Assembler::kNearJump);
@@ -2021,7 +2011,7 @@
Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ movq(RAX, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(RAX);
__ movzxb(RAX, Address(RAX, Isolate::single_step_offset()));
__ cmpq(RAX, Immediate(0));
__ j(NOT_EQUAL, &stepping);
« no previous file with comments | « runtime/vm/stub_code_mips_test.cc ('k') | runtime/vm/stub_code_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698